You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General coding rule to detect usages of old time and date classes (#1384 / #1385)
With this commit new general rules are added which detect the usages of old
time and date classes, e.g. java.util.Date.
closes #1384
I would like to provide rules for #1384, but I'm failing with the OLD_DATE_AND_TIME_CLASSES_SHOULD_NOT_BE_USED_should_fail_when_class_uses_java_util_date test as my violation is not captured, but this
[violation details (should have some detail containing 'since Java 8 (and JavaEE 7 if JPA is needed) java.time-API should be used.')]
Expecting any elements of:
["Method <com.tngtech.archunit.library.testclasses.timeapi.incorrect.UsesJavaUtilDate.usesJavaUtilDate()> calls method <java.util.Date.from(java.time.Instant)> in (UsesJavaUtilDate.java:9)"]
to match given predicate but none did.
java.lang.AssertionError: [violation details (should have some detail containing 'since Java 8 (and JavaEE 7 if JPA is needed) java.time-API should be used.')]
Expecting any elements of:
["Method <com.tngtech.archunit.library.testclasses.timeapi.incorrect.UsesJavaUtilDate.usesJavaUtilDate()> calls method <java.util.Date.from(java.time.Instant)> in (UsesJavaUtilDate.java:9)"]
to match given predicate but none did.
Can anyone give me a hint how to fix that?
P.S. I know that my formatting (e.g. star import) are not yet correct. Will fix this when my tests are working and before changing this draft into a real PR, including providing a real commit message.
Bukama
changed the title
General Coding rule to detect usages of old time and date classes (DRAFT for #1384)
General Coding rule to detect usages of old time and date classes (#1384 / #1385)
Nov 28, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bukama
changed the title
Update:
Provided commit message
I would like to provide rules for #1384, but I'm failing with the
OLD_DATE_AND_TIME_CLASSES_SHOULD_NOT_BE_USED_should_fail_when_class_uses_java_util_datetest as my violation is not captured, but thisCan anyone give me a hint how to fix that?
P.S. I know that my formatting (e.g. star import) are not yet correct. Will fix this when my tests are working and before changing this draft into a real PR, including providing a real commit message.